Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Failed Message #3

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Show Failed Message #3

wants to merge 30 commits into from

Conversation

rodnaph
Copy link

@rodnaph rodnaph commented Jan 11, 2023

Adds a route for displaying failed messages.

image

@rodnaph rodnaph force-pushed the show-failed-message branch 5 times, most recently from b160e2c to 603bdf6 Compare January 12, 2023 09:56
bocharsky-bw and others added 25 commits March 27, 2023 09:28
…zed spot (bocharsky-bw)

This PR was squashed before being merged into the master branch.

Discussion
----------

Reuse some GitHub CI config files from centralized spot

Reused as much as I can... not sure if we need to worry about those `tests-mariadb` & `tests-posgress`, they look more specific to this repo

Test failures unrelated, those builds are failed in master too

Commits
-------

3a193d0 Reuse some GitHub CI config files from centralized spot
This PR was squashed before being merged into the master branch.

Discussion
----------

Fix CI, test on php 8.2

This PR:

1. fixes the CI failures
2. tests againsts php 8.2 in CI
3. use same version of php-cs-fixer in the repo as is used in https://github.com/SymfonyCasts/.github/blob/main/.github/workflows/php-cs-fixer.yaml (this is a bit brittle as they need to be kept in sync - also needs doing for psalm)

shall we drop php 8.0 since it is no longer maintained?

Commits
-------

56a7880 Fix CI, test on php 8.2
Adding note that this bundle is unstable & experimental
…ch-1

Convert note into GitHub note and minor formatting tweaks in README
- `composer tools:run` runs `php-cs-fixer` & `phpstan`
- `composer tools:run:php-cs-fixer` run only `php-cs-fixer` (works for `phpstan` as well).
- `composer tools:upgrade` upgrades / installs all of the `tools/*`
- `composer tools:upgrade:php-cs-fixer` Upgrades / installs only `php-cs-fixer` (works for `phpstan` as well)
Event subscribers are deprecated in orm 2.x and removed in 3.x.
…tener (kbond)

This PR was merged into the main branch.

Discussion
----------

fix: switch from Doctrine event subscriber to listener

Event subscribers are deprecated in orm 2.x and removed in 3.x.

Commits
-------

3d35da3 fix: switch from Doctrine event subscriber to listener
This should help with noticing failed CI builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants